Skip to content

feat: add vm-migration-network setting #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

FrankYang0529
Copy link
Member

Problem:

Solution:

Related Issue(s):

harvester/harvester#5848

Test plan:

Additional documentation or context

Copy link

github-actions bot commented Jun 30, 2025

Name Link
🔨 Latest commit 1b49e7c
😎 Deploy Preview https://6889bcee036daa91d403f022--harvester-preview.netlify.app

Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Just a few feedback.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. Note that the structural changes that I suggested here will be applied to the "Storage Network" page as well. I will create the PR after we merge this one.

FrankYang0529 and others added 15 commits July 30, 2025 11:39
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants