-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add vm-migration-network setting #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM. Just a few feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done. Note that the structural changes that I suggested here will be applied to the "Storage Network" page as well. I will create the PR after we merge this one.
Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Problem:
Solution:
Related Issue(s):
harvester/harvester#5848
Test plan:
Additional documentation or context